Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Extend multiple space selection details #8230

Merged
merged 10 commits into from
Jan 18, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jan 13, 2023

Description

See #8222

Related Issue

Screenshots (if appropriate):

Screenshot (29)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jan 13, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat force-pushed the admin-panel-multiple-space-selection branch from bb80d71 to 6d2ceb8 Compare January 13, 2023 14:27
@lookacat lookacat changed the title Extend multiple space selection details [full-ci] Extend multiple space selection details Jan 13, 2023
@lookacat lookacat force-pushed the admin-panel-multiple-space-selection branch from 28a6450 to 771e081 Compare January 16, 2023 09:23
@lookacat lookacat marked this pull request as ready for review January 16, 2023 09:37
@lookacat lookacat requested a review from kulmann January 16, 2023 09:47
@lookacat lookacat force-pushed the admin-panel-multiple-space-selection branch from 6d10757 to 08bebf9 Compare January 17, 2023 08:53
@lookacat lookacat force-pushed the admin-panel-multiple-space-selection branch from 08bebf9 to 691e755 Compare January 17, 2023 11:58
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳 Minor nitpick, approving anyway since it's a "code-readability"-thing.

@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.1% 86.1% Coverage
0.0% 0.0% Duplication

@lookacat lookacat dismissed kulmann’s stale review January 18, 2023 08:37

changes done, PR. was approved

@lookacat lookacat merged commit 552dd5a into master Jan 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the admin-panel-multiple-space-selection branch January 18, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Web] Show Info for multiple selected spaces
4 participants