-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Extend multiple space selection details #8230
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
bb80d71
to
6d2ceb8
Compare
28a6450
to
771e081
Compare
packages/web-pkg/src/components/sideBar/Spaces/Details/SpaceDetailsMultiple.vue
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/components/sideBar/Spaces/Details/SpaceDetailsMultiple.vue
Outdated
Show resolved
Hide resolved
packages/web-pkg/tests/unit/components/sidebar/Spaces/Details/SpaceDetailsMultiple.spec.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/tests/unit/components/sidebar/Spaces/Details/SpaceDetailsMultiple.spec.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/components/sideBar/Spaces/Details/SpaceDetailsMultiple.vue
Show resolved
Hide resolved
packages/web-pkg/src/components/sideBar/Spaces/Details/SpaceDetailsMultiple.vue
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/components/sideBar/Spaces/Details/SpaceDetailsMultiple.vue
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/components/sideBar/Spaces/Details/SpaceDetailsMultiple.vue
Outdated
Show resolved
Hide resolved
6d10757
to
08bebf9
Compare
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/31725/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31725/tracing/participant-management-alice-2023-1-17-12-57-23.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31725/tracing/participant-management-anonymous-2023-1-17-12-57-57.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31725/tracing/participant-management-brian-2023-1-17-12-57-32.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31725/tracing/participant-management-carol-2023-1-17-12-57-45.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31725/tracing/participant-management-marie-2023-1-17-12-57-36.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31725/tracing/participant-management-richard-2023-1-17-12-57-40.zip |
08bebf9
to
691e755
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥳 Minor nitpick, approving anyway since it's a "code-readability"-thing.
packages/web-pkg/src/components/sideBar/Spaces/Details/SpaceDetailsMultiple.vue
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/components/sideBar/Spaces/Details/SpaceDetailsMultiple.vue
Outdated
Show resolved
Hide resolved
SonarCloud Quality Gate failed. |
Description
See #8222
Related Issue
Screenshots (if appropriate):
Types of changes
Checklist: